Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ext/node): Disable prefer-primordials on a per-file basis #19553

Merged

Conversation

petamoriken
Copy link
Contributor

For the moment, I disabled prefer-primordials on a per-file basis so that newly created files would comply with prefer-primordials.

@petamoriken petamoriken changed the title Refactor(ext/node): Disable prefer-primordials on a per-file basis refactor(ext/node): Disable prefer-primordials on a per-file basis Jun 19, 2023
@petamoriken petamoriken force-pushed the refactor/prefer-primordials-for-node-polyfills branch from ed1831a to 67859d1 Compare June 26, 2023 03:51
@petamoriken
Copy link
Contributor Author

@kt3k Please take a look in your time!

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k kt3k merged commit e16b74d into denoland:main Jun 27, 2023
10 checks passed
@petamoriken petamoriken deleted the refactor/prefer-primordials-for-node-polyfills branch June 27, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants