Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Stabilize Deno.serve() API #19141

Merged
merged 14 commits into from
Jul 3, 2023
Merged

feat: Stabilize Deno.serve() API #19141

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
813a189
feat: Stabilize Deno.serve() API
bartlomieju May 16, 2023
f60914a
update test
bartlomieju May 16, 2023
77dc6c2
Merge branch 'main' into stabilize_deno_serve
bartlomieju Jun 28, 2023
62438ea
revert changes to Cargo.lock
bartlomieju Jun 28, 2023
d6ce399
updates after merge
bartlomieju Jun 28, 2023
09ea311
fix type decl
bartlomieju Jun 28, 2023
613b8df
fix examples in type decl
bartlomieju Jun 28, 2023
b74d39c
Merge branch 'main' into stabilize_deno_serve
bartlomieju Jul 3, 2023
a5cb59f
don't extend Deno.ListenOptions
bartlomieju Jul 3, 2023
a7b3b80
always bind to port 8000 by default
bartlomieju Jul 3, 2023
d91980f
update a test
bartlomieju Jul 3, 2023
e212bbe
Merge branch 'main' into stabilize_deno_serve
bartlomieju Jul 3, 2023
be384ee
update documentation
bartlomieju Jul 3, 2023
d7d8b1d
Merge branch 'main' into stabilize_deno_serve
bartlomieju Jul 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
always bind to port 8000 by default
  • Loading branch information
@bartlomieju
bartlomieju committed Jul 3, 2023
commit a7b3b80961b1ddf78577141be392a9a195ab5b89
6 changes: 3 additions & 3 deletions cli/tests/unit/serve_test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3077,16 +3077,16 @@ Deno.test(

assertEquals(
"hello world!",
await curlRequest(["https://localhost:9000/path", "-k"]),
await curlRequest(["https://localhost:8000/path", "-k"]),
);
assertEquals(
"hello world!",
await curlRequest(["https://localhost:9000/path", "-k", "--http2"]),
await curlRequest(["https://localhost:8000/path", "-k", "--http2"]),
);
assertEquals(
"hello world!",
await curlRequest([
"https://localhost:9000/path",
"https://localhost:8000/path",
"-k",
"--http2",
"--http2-prior-knowledge",
Expand Down
2 changes: 1 addition & 1 deletion ext/http/00_serve.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -613,7 +613,7 @@ function serve(arg1, arg2) {
};
const listenOpts = {
hostname: options.hostname ?? "0.0.0.0",
port: options.port ?? (wantsHttps ? 9000 : 8000),
port: options.port ?? 8000,
reusePort: options.reusePort ?? false,
};

Expand Down
Loading