chore: restore pty tests and make them run on the Linux CI #18424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
commented
Mar 28, 2023
|
|
||
| for item in deno_ast::lex(input, deno_ast::MediaType::TypeScript) { | ||
| let current_line_index = line_info.line_index(item.range.start); | ||
| let mut queued_validation_error = None; |
There was a problem hiding this comment.
The change here fixes another regression due to swc not having regex literals as tokens anymore. A pty test pointed this out.
dsherret
commented
Mar 28, 2023
| )) | ||
| } | ||
|
|
||
| pub fn run(&self) -> TestCommandOutput { |
There was a problem hiding this comment.
Most of the below except cwd and args isn't new. The diff is just not great.
dsherret
commented
Mar 28, 2023
| @@ -511,33 +539,30 @@ impl TestCommandOutput { | |||
| .expect("call .split_output() on the builder") | |||
| } | |||
|
|
|||
| #[track_caller] | |||
There was a problem hiding this comment.
See https://blog.rust-lang.org/2020/08/27/Rust-1.46.0.html#track_caller
I just learned about this and it works way better than the failed_position() thing.
bartlomieju
approved these changes
Mar 28, 2023
| @@ -511,33 +539,30 @@ impl TestCommandOutput { | |||
| .expect("call .split_output() on the builder") | |||
| } | |||
|
|
|||
| #[track_caller] | |||
mmastrac
pushed a commit
that referenced
this pull request
Mar 31, 2023
1. Rewrites the tests to be more back and forth rather than getting the output all at once (which I believe was causing the hangs on linux and maybe mac) 2. Runs the pty tests on the linux ci. 3. Fixes a bunch of tests that were just wrong. 4. Adds timeouts on the pty tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The repl tests now run on my system again. I will test on linux in a second.The tests didn't run on linux, so I'm rewriting them.This does a few things:
Closes #18129- Hangs on mac