Rewrite tools/format.py in deno #1528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harrysarson
reviewed
Jan 15, 2019
| - ./tools/build.py -C target/release | ||
| - ./tools/test_format.py |
There was a problem hiding this comment.
Hi, I may be wrong but there be a ts extension here, not py?
There was a problem hiding this comment.
No, this script is still in python. (I replaced format.py with format.ts, but test_format.py is still written in python. I think that rewriting that script in deno is another good first issue.)
1c3e1cb
to
62a6e38
Compare
|
@ry Yes, I used the idea of |
ry
reviewed
Jan 15, 2019
tools/test_format.py
Outdated
| @@ -8,11 +9,11 @@ | |||
|
|
|||
|
|
|||
| def main(): | |||
| util.run([sys.executable, "tools/format.py"]) | |||
| util.run(["target/release/deno", "--allow-run", "tools/format.ts"]) | |||
There was a problem hiding this comment.
- I'm not sure how this works on Windows, because it should need the
.exeextension. Useexecutable_suffixinutil.py - In certainly situations we might have
target/debug/denoand not the release one. It would be good to check for existence of each, preferring the release one.
There was a problem hiding this comment.
I added code to choose deno in preference of release -> debug -> globally installed version.
11f12ac
to
0075893
Compare
Note: findFiles and findFilesWalk are borrowed from the previous attempt of @pseudo-su (denoland#1434). Thanks!
0075893
to
f5e9588
Compare
ry
added a commit
to ry/deno
that referenced
this pull request
Feb 12, 2019
tools/format.ts is making CI flaky and it's difficult to run right now. Reverting to tools/format.py This reverts commit f19622e.
ry
added a commit
to ry/deno
that referenced
this pull request
Feb 12, 2019
tools/format.ts is making CI flaky and it's difficult to run right now. Reverting to tools/format.py This reverts commit f19622e.
ry
added a commit
that referenced
this pull request
Feb 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1319