Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ext/net): support SOA records, support DNS zone file for testing #14534

Merged
merged 12 commits into from
May 14, 2022
Merged

feat(ext/net): support SOA records, support DNS zone file for testing #14534

merged 12 commits into from
May 14, 2022

Conversation

PatrickChoDev
Copy link
Contributor

This is new recreated PR from #14374.

Add SOA record type support for Deno.resolveDns()

@cmorten cmorten mentioned this pull request May 8, 2022
Open
4 tasks
@PatrickChoDev PatrickChoDev changed the title feat(ext/net): support SOA record type for resolveDns feat(ext/net): support DNS zone file for testing May 8, 2022
@bartlomieju bartlomieju changed the title feat(ext/net): support DNS zone file for testing feat(ext/net): support SOA records, support DNS zone file for testing May 10, 2022
bartlomieju
bartlomieju approved these changes May 10, 2022
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju added this to the 1.22 milestone May 10, 2022
@bartlomieju bartlomieju merged commit bd42562 into denoland:main May 14, 2022
@PatrickChoDev PatrickChoDev deleted the feat/net-soa branch May 14, 2022 14:21
@PatrickChoDev PatrickChoDev restored the feat/net-soa branch May 14, 2022 14:21
@cmorten cmorten mentioned this pull request May 15, 2022
Merged
sigmaSd pushed a commit to sigmaSd/deno that referenced this pull request May 29, 2022
@PatrickChoDev @sigmaSd
feat(ext/net): add support for SOA records in Deno.resolveDns() API (d…
ed9742b 
…enoland#14534)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

@crowlKats crowlKats Awaiting requested review from crowlKats

@lucacasonato lucacasonato Awaiting requested review from lucacasonato

@littledivy littledivy Awaiting requested review from littledivy

@kitsonk kitsonk Awaiting requested review from kitsonk

@kt3k kt3k Awaiting requested review from kt3k

@piscisaureus piscisaureus Awaiting requested review from piscisaureus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.22
Development

Successfully merging this pull request may close these issues.
2 participants
@PatrickChoDev @bartlomieju