Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(test): better formatting for test elapsed time #12610

Merged
merged 3 commits into from
Oct 30, 2021
Merged

feat(test): better formatting for test elapsed time #12610

merged 3 commits into from
Oct 30, 2021

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Oct 30, 2021 •
edited
Loading

Closes #12609

dsherret
dsherret approved these changes Oct 30, 2021
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but probably needs it for test case reporting too

cli/tools/test.rs Outdated Show resolved Hide resolved
cli/tools/test.rs Outdated Show resolved Hide resolved
@bartlomieju
Copy link
Member Author

bartlomieju commented Oct 30, 2021 •
edited
Loading

LGTM, but probably needs it for test case reporting too

Yeah, not a big deal for "ms" and "s", but I don't want to add a test that takes more than a minute just to assert it outputs (1m1s) 😬

EDIT: OTOH integration tests take minutes anyway, so maybe that's not a big deal

@dsherret
Copy link
Member

@bartlomieju we could unit test human_elapsed. I don't think testing the structs at a higher level/integration tests are necessary.

@bartlomieju
Copy link
Member Author

@bartlomieju we could unit test human_elapsed. I don't think testing the structs at a higher level/integration tests are necessary.

SGTM, I'll do that.

@bartlomieju bartlomieju merged commit e06515c into denoland:main Oct 30, 2021
@bartlomieju bartlomieju deleted the human_readable_elapsed branch October 30, 2021 20:49
@meszarosdezso meszarosdezso mentioned this pull request Oct 31, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Unit Tests] Human Readable Timer For Long Tests
2 participants
@bartlomieju @dsherret