fix(tsc): add .at() types manually to tsc, update to tsc v4.3.5 #11443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #11441
This manually adds the types for
.at()types to arrays and strings. It is a bit "hacky", but essentially the same way we add"dom.asynciterable"to TypeScript.Something we should revert once in a released version of TypeScript (but will likely just overwrite when it is finally included).
Added a simply js_unit test which validates that it should pass type checking.
Also updated to the latest release version of TypeScript (4.3.2 -> 4.3.5).