Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark wanted: copy throughput #890

Closed
ry opened this issue Oct 3, 2018 · 4 comments
Closed

Benchmark wanted: copy throughput #890

ry opened this issue Oct 3, 2018 · 4 comments

Comments

@ry
Copy link
Member

ry commented Oct 3, 2018

outlined here: #884 (comment)

Should wait for #884 to land.

In the future we will want to compare it to TLS throughput.

It makes sense to also compare it to a program that measures stdio throughput:

// time head -c 100000000 /dev/zero | deno this_script.js
import * as deno from "deno";
deno.copy(deno.stdout, deno.stdin);
@ry ry changed the title Benchmark wanted: TCP echo server throughput Benchmark wanted: copy throughput Oct 3, 2018
@ghost
Copy link

ghost commented Oct 9, 2018

What counterpart should it compare with? Golang? You need to set a performance goal such as "it should be similar to Golang". Then we need to port all benchmarks to (for instance) Golang so that we get relative numbers and not just "1 million unnamed units of performance". You want to get numbers like "0.79x of Golang".

@ry
Copy link
Member Author

ry commented Oct 9, 2018

No counterpart needed for the first version - would like to just get continuous look at the perf

@ghost
Copy link

ghost commented Oct 9, 2018

I can't get any of the examples to work on Windows or Linux. Deno just exits as soon as there's a connection. I downloaded the 0.1.7 binaries.

This is what I ran:

import * as deno from "deno";
let listener = deno.listen("tcp", "127.0.0.1:4500");
listener.accept().then(async (conn) => {
  await deno.copy(conn, conn);
  conn.close();
  listener.close();
});

@ry
Copy link
Member Author

ry commented Oct 9, 2018

Likely you are experiencing #919
We’ll have a new release in a day or two

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant