Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make welcome.ts more welcoming #8356

Closed
MarkTiedemann opened this issue Nov 11, 2020 · 2 comments · Fixed by #9031
Closed

Make welcome.ts more welcoming #8356

MarkTiedemann opened this issue Nov 11, 2020 · 2 comments · Fixed by #9031
Labels
docs suggestion suggestions for new features (yet to be agreed)

Comments

@MarkTiedemann
Copy link
Contributor

MarkTiedemann commented Nov 11, 2020

First run on Windows after reading the readme:

C:\> deno run https://deno.land/std/examples/welcome.ts
Download https://deno.land/std/examples/welcome.ts
Warning Implicitly using latest version (0.77.0) for https://deno.land/std/examples/welcome.ts
Download https://deno.land/[email protected]/examples/welcome.ts
Check https://deno.land/std/examples/welcome.ts
Welcome to Deno �
  • Prints a warning
  • Prints unicode tofu

Also, if you want to check the script you are supposed to run before running it, a quick curl is empty:

C:\> curl https://deno.land/std/examples/welcome.ts

Since it redirects, -L is required.

How about changing the script to:

// Copyright 2018-2020 the Deno authors. All rights reserved. MIT license
if (Deno.build.os === "windows") {
  console.log("Welcome to Deno!");
} else {
  console.log("Welcome to Deno 🦕");
}
// Or equivalent:
// console.log(`Welcome to Deno${Deno.build.os === "windows" ? "!" : " 🦕"}`);

And placing it at https://deno.land/welcome.ts - without any redirects?

@PaintNinja
Copy link

PaintNinja commented Nov 12, 2020

It should be noted that the Windows Terminal supports emojis and works properly, only legacy Windows consoles such as conhost show the unknown unicode symbol.

@kitsonk kitsonk added docs suggestion suggestions for new features (yet to be agreed) labels Nov 12, 2020
@MarkTiedemann
Copy link
Contributor Author

Similarly, it should be noted that the Windows Terminal is an (optional) app that users can install from the Microsoft Store (if they know that the Microsoft Store exists (and if they know that it contains an app called Windows Terminal)), which had its first stable release half a year ago, whereas the "legacy console" is installed on roughly 90% of desktop computers world-wide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs suggestion suggestions for new features (yet to be agreed)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants