Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub proxy via x (like "x/gh:githubusername:repo@tag") deprecated? #7151

Closed
josephrocca opened this issue Aug 21, 2020 · 2 comments
Closed

Comments

@josephrocca
Copy link
Contributor

josephrocca commented Aug 21, 2020

It was previously possible to import a package from GitHub like this:

https://deno.land/x/gh:githubusername:[email protected]/mod.js

I can't find any notice about this being deprecated - I only noticed today when I tried to run an old-ish script. If it is deprecated, maybe this could be added as a message on the resulting 404 page? I'm happy to make a pull request for this. I'd just chance "This module does not exist." to something like "This module does not exist. The github proxy has been deprecated."

Also, if it was deprecated (i.e. this isn't a bug) was this discussed somewhere? I like deno's strong backwards-compatibility guarantees for the runtime and would hope that this philosophy spills over into other areas. That said, in these early days of deno a deprecation like this certainly has a lower cost and might be worth it.

@lcasdev
Copy link

lcasdev commented Aug 21, 2020

Yes this is deprecated. We recently rolled out an update to the registry: https://deno.land/posts/registry2. This was incompatible with the /x/gh: and /x/npm: links, so they had to be removed (we always labeled these as experimental). We had a deprecation notice on these files for a month before actually disabling them. Sorry for the inconvenience

@josephrocca
Copy link
Contributor Author

josephrocca commented Aug 21, 2020

Ah okay - no worries! Reading through that blog post it's clear the trade-off was worth it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants