Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

treat warnings as errors #374

Closed
ry opened this issue Jul 17, 2018 · 4 comments · Fixed by #379
Closed

treat warnings as errors #374

ry opened this issue Jul 17, 2018 · 4 comments · Fixed by #379

Comments

@ry
Copy link
Member

ry commented Jul 17, 2018 •
edited

https://github.com/ry/deno/blob/ed9acaec7d438515271c1f2664780c0612f339da/.gn#L28
The task is to delete this line and deal with all the warnings that cause the build to fail. There are a handful. Bonus points if you make rustc warnings also obey the treat_warnings_as_errors gn arg.
@ry ry changed the title Error on warnings treat warnings as errors Jul 17, 2018
@robbym
Copy link
Contributor

robbym commented Jul 17, 2018 •
edited

Just need to add -Dwarnings to rustc args. Not familiar enough with gn to do this. Something like this in rust.gni?

template("run_rustc") {

...

    if (defined(treat_warnings_as_errors) && treat_warnings_as_errors) {
      args += ["-Dwarnings"]
    }

...

}

Doesn't seem to work though.

@ry ry mentioned this issue Jul 17, 2018
Merged
kt3k added a commit to kt3k/deno that referenced this issue Jul 18, 2018
@kt3k
chore: error on warnings
9504fba 
refs: denoland#374
kt3k added a commit to kt3k/deno that referenced this issue Jul 18, 2018
@kt3k
chore: error on warnings
f608b1f 
refs: denoland#374
@kt3k kt3k mentioned this issue Jul 18, 2018
Merged
kt3k added a commit to kt3k/deno that referenced this issue Jul 18, 2018
@kt3k
chore: error on warnings
e2eb270 
refs: denoland#374
kt3k added a commit to kt3k/deno that referenced this issue Jul 19, 2018
@kt3k
chore: error on warnings
43be9d5 
refs: denoland#374
@ry ry closed this as completed in #379 Jul 21, 2018
@ry ry reopened this Aug 17, 2018
@ry ry added this to the future milestone Aug 17, 2018
@ry
Copy link
Member Author

ry commented Aug 17, 2018

This was accidentally closed. We will have a number of warnings popping up.

#536 significantly reduces the number of rust warnings

ry added a commit that referenced this issue Aug 29, 2018
@ry
Fix warnings.
4fd636a 
Ref #374
ry added a commit that referenced this issue Aug 30, 2018
@ry
Fix warnings.
902e6e2 
Ref #374
@ry
Copy link
Member Author

ry commented Sep 4, 2018

OSX and Linux builds are warning free now.

@ry
Copy link
Member Author

ry commented Sep 18, 2018

Rust warnings have been made errors in 850fca8

Just need to deal with clang errors now.

@ry ry mentioned this issue Oct 25, 2018
Merged
@ry ry closed this as completed in #1086 Oct 26, 2018
ry added a commit that referenced this issue Oct 26, 2018
@ry
Turn on treat_warnings_as_errors (#1086)
59acd8d 
Fixes #374
piscisaureus pushed a commit to piscisaureus/deno that referenced this issue Oct 7, 2019
@ry
http_bench: print address (denoland#374)
f10ea73
hardfist pushed a commit to hardfist/deno that referenced this issue Aug 7, 2024
@mmastrac
chore: port dyn_import_circular to integration test (denoland#374)
ce14fa3 
Port another test to checkin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Treat warnings as errors kt3k/deno
2 participants
@ry @robbym