-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
treat warnings as errors #374
Comments
Just need to add template("run_rustc") {
...
if (defined(treat_warnings_as_errors) && treat_warnings_as_errors) {
args += ["-Dwarnings"]
}
...
} Doesn't seem to work though. |
kt3k
added a commit
to kt3k/deno
that referenced
this issue
Jul 18, 2018
kt3k
added a commit
to kt3k/deno
that referenced
this issue
Jul 18, 2018
kt3k
added a commit
to kt3k/deno
that referenced
this issue
Jul 18, 2018
kt3k
added a commit
to kt3k/deno
that referenced
this issue
Jul 19, 2018
This was accidentally closed. We will have a number of warnings popping up. #536 significantly reduces the number of rust warnings |
OSX and Linux builds are warning free now. |
Rust warnings have been made errors in 850fca8 Just need to deal with clang errors now. |
ry
added a commit
that referenced
this issue
Oct 26, 2018
piscisaureus
pushed a commit
to piscisaureus/deno
that referenced
this issue
Oct 7, 2019
hardfist
pushed a commit
to hardfist/deno
that referenced
this issue
Aug 7, 2024
Port another test to checkin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
https://github.com/ry/deno/blob/ed9acaec7d438515271c1f2664780c0612f339da/.gn#L28
The task is to delete this line and deal with all the warnings that cause the build to fail. There are a handful. Bonus points if you make rustc warnings also obey the
treat_warnings_as_errors
gn arg.The text was updated successfully, but these errors were encountered: