Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

need a way to get deno_std version of current Deno #3395

Closed
axetroy opened this issue Nov 23, 2019 · 7 comments · Fixed by #3415
Closed

need a way to get deno_std version of current Deno #3395

axetroy opened this issue Nov 23, 2019 · 7 comments · Fixed by #3415

Comments

@axetroy
Copy link
Contributor

axetroy commented Nov 23, 2019

$ deno --version
deno: 0.24.0
v8: 8.0.192
typescript: 3.7.2
std: 0.23.0
console.log(Deno.versions);

/*
{
  "deno": "0.24.0",
  "v8": "8.0.192",
  "typescript": "3.7.2",
  "std": "0.23.0"
}
*/

interface Version {
deno: string;
v8: string;
typescript: string;
}

deno/cli/flags.rs

Lines 15 to 19 in c6bb3d5

macro_rules! std_url {
($x:expr) => {
concat!("https://deno.land/[email protected]/", $x)
};
}

@ry
Copy link
Member

ry commented Nov 23, 2019

I think std version is confusing to users...

Also I will be removing the "v8" and "typescript" parts of the output in #3389.

@axetroy
Copy link
Contributor Author

axetroy commented Nov 23, 2019

Even if it is not output on the command line, it should be exported in Deno.versions

This is to facilitate future tool integration.

eg. third-party tools use deno install

It can know the version of std for current Deno version, and download the dependencies in advance.

@axetroy axetroy changed the title Show current using deno_std version in deno --version need a way to get deno_std version of current Deno Nov 23, 2019
@nayeemrmn
Copy link
Collaborator

Even if it is not output on the command line, it should be exported in Deno.versions

But it's only applicable on the command line... I think we just need to figure out how to make the versions align again.

@Fenzland
Copy link
Contributor

You may both import [email protected], [email protected] in your file and run with deno 0.25. So I think a std version in deno --version output is meaningless.

@ry
Copy link
Member

ry commented Dec 5, 2019

reopening. See #3446

@ry ry reopened this Dec 5, 2019
@rsp
Copy link
Contributor

rsp commented Dec 11, 2019

You may both import [email protected], [email protected] in your file and run with deno 0.25. So I think a std version in deno --version output is meaningless.

@Fenzland, yes I can import old versions of std in newer runtimes, but is all of the Deno API that is used by all of std modules guaranteed to be backwards compatible? This is not a rhetorical question, it would be good to know if old std versions will continue working with all new versions of Deno, or the other way around, or none of the above. This is a strategic decision for @ry to consider, not a simple one, as I tried to explain in #3320.

@axetroy
Copy link
Contributor Author

axetroy commented Feb 14, 2020

I think this item is outdated

close

@axetroy axetroy closed this as completed Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants