Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow unstable feature flags to have different forms #21604

Open
ry opened this issue Dec 16, 2023 · 1 comment
Open

Allow unstable feature flags to have different forms #21604

ry opened this issue Dec 16, 2023 · 1 comment
Labels
cli related to cli/ dir node compat suggestion suggestions for new features (yet to be agreed)

Comments

@ry
Copy link
Member

ry commented Dec 16, 2023 •
edited
Loading

In particular --unstable-unsafe-proto is unnecessarily long. It would be nice to have --enable-proto also as an alias which would correspond nicely to Node's --disable-proto
@dsherret
Copy link
Member

Not sure about the title of this. The reason it's long is because it's unstable. For example, this could just be --unsafe-proto once stabilized, which is the same length as --enable-proto. It might be good to have "unsafe" in the name to hammer in why this is not enabled by default and to give people pause when they see it in codebases.

@lucacasonato lucacasonato added suggestion suggestions for new features (yet to be agreed) and removed proposal labels Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cli related to cli/ dir node compat suggestion suggestions for new features (yet to be agreed)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ry @dsherret @lucacasonato @littledivy