bug: Deno.noColor returns true in canary

[iuioiua]

Yesterday, CI in the Standard Library for Deno canary started failing because of failing tests in std/fmt/colors_test.ts. After some troubleshooting, it appears they're failing because Deno.noColor is now returning true for some reason. However, in stable, Deno.noColor returns false, and the tests pass fine.

I believe this behaviour was changed in either #20720 or #21191. This issue arose around the same time as these PRs being merged, and they both touch ext/console/01_console.js, which contains some of the code that implements Deno.noColor. However, the revert has not fixed the issue.

[bartlomieju]

CC @littledivy I think this might be related to lazy loading of this value?

[kt3k]

Maybe related to this issue, but cli/tests/unit/tty_color_test.ts doesn't seem passing in main. Never mind. it was caused by my modification

[kt3k]

I think there was a confusion between noColor for console log coloring and Deno.noColor variable in #21164. It looks that the former is based on NO_COLOR env var and terminal state of stdout, but the latter is only based on NO_COLOR env var. I'll work on the fix.