Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Box-drawing characters in the permission prompt is broken #17244

Closed
nsfisis opened this issue Jan 2, 2023 · 1 comment · Fixed by #17249
Closed

CLI: Box-drawing characters in the permission prompt is broken #17244

nsfisis opened this issue Jan 2, 2023 · 1 comment · Fixed by #17249

Comments

@nsfisis
Copy link

nsfisis commented Jan 2, 2023

Environment

$ deno --version
deno 1.29.1 (release, x86_64-unknown-linux-gnu)
v8 10.9.194.5
typescript 4.9.4
  • OS: Ubuntu 22.04
  • Terminal: Alacritty v0.11.0 or Ubuntu's bundled Terminal app
  • Font: Ubuntu Mono 13

Problem

Box-drawing characters in the permission prompt is broken.

Screenshot

image

Cause

The box-drawing character is printed in italic style.

runtime/permissions/prompter.rs

    let msg = format!(
      "   ├ Run again with --allow-{} to bypass this prompt.",
      name
    );
    eprintln!("{}", colors::italic(&msg));

This code should be like:

    let msg = format!(
      "Run again with --allow-{} to bypass this prompt.",
      name
    );
    eprintln!("   ├ {}", colors::italic(&msg));

(not tested)

@bartlomieju
Copy link
Member

Thanks for the report, fixed in #17249

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants