Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support NO_COLOR env var #1706

Closed
ry opened this issue Feb 7, 2019 · 5 comments
Closed

support NO_COLOR env var #1706

ry opened this issue Feb 7, 2019 · 5 comments

Comments

@ry
Copy link
Member

ry commented Feb 7, 2019

https://no-color.org/
@ry
Copy link
Member Author

ry commented Feb 8, 2019

first pass in #1698 but need to be able to filter typescript color messages too. Maybe should add deno.NO_COLOR for user code to check without requiring --allow-env

@kitsonk
Copy link
Contributor

kitsonk commented Feb 8, 2019

Instead of trying to filter messages in TypeScript, we should just have the compiler set pretty: false on the TypeScript compiler options when NO_COLOR is present (I checked and TypeScript doesn't check this itself, it just assumes that no one would pass the --pretty flag).

@hayd
Copy link
Contributor

hayd commented Feb 8, 2019

You also want to be able to support this in the front-end e.g. if adding color to console.error (or a user function).

@ry ry mentioned this issue Feb 8, 2019
Merged
@ry
Copy link
Member Author

ry commented Feb 8, 2019

I've added deno.noColor in #1716

@ry ry mentioned this issue Feb 8, 2019
Merged
@ry
Copy link
Member Author

ry commented Feb 9, 2019

NO_COLOR works for the most part now.

@ry ry closed this as completed Feb 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ry @kitsonk @hayd