Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test integration::test::pass is flaky #14570

Closed
dsherret opened this issue May 11, 2022 · 0 comments · Fixed by #14571
Closed

test integration::test::pass is flaky #14570

dsherret opened this issue May 11, 2022 · 0 comments · Fixed by #14571
Labels
flaky a test is not reliable or determinstic

Comments

@dsherret
Copy link
Member

dsherret commented May 11, 2022

Looks like the console.log and console.error lines are swapped. For the test output it's not reliable which one gets outputted first.

failures:

---- integration::test::pass stdout ----
deno_exe path /home/runner/work/deno/deno/target/release/deno
deno_exe args test test/pass.ts
deno_exe testdata path "/home/runner/work/deno/deno/cli/tests/testdata"
output path /home/runner/work/deno/deno/cli/tests/testdata/test/pass.out
[test_util/src/lib.rs:1882] part = "/test/pass.ts\nrunning 10 tests from ./test/pass.ts\ntest 0 ... ok ("
[test_util/src/lib.rs:1882] i = 1
[test_util/src/lib.rs:1888] "found " = "found "
[test_util/src/lib.rs:1888] found = 53
[test_util/src/lib.rs:1882] part = ")\ntest 1 ... ok ("
[test_util/src/lib.rs:1882] i = 2
[test_util/src/lib.rs:1888] "found " = "found "
[test_util/src/lib.rs:1888] found = 3
[test_util/src/lib.rs:1882] part = ")\ntest 2 ... ok ("
[test_util/src/lib.rs:1882] i = 3
[test_util/src/lib.rs:1888] "found " = "found "
[test_util/src/lib.rs:1888] found = 3
[test_util/src/lib.rs:1882] part = ")\ntest 3 ... ok ("
[test_util/src/lib.rs:1882] i = 4
[test_util/src/lib.rs:1888] "found " = "found "
[test_util/src/lib.rs:1888] found = 3
[test_util/src/lib.rs:1882] part = ")\ntest 4 ... ok ("
[test_util/src/lib.rs:1882] i = 5
[test_util/src/lib.rs:1888] "found " = "found "
[test_util/src/lib.rs:1888] found = 3
[test_util/src/lib.rs:1882] part = ")\ntest 5 ... ok ("
[test_util/src/lib.rs:1882] i = 6
[test_util/src/lib.rs:1888] "found " = "found "
[test_util/src/lib.rs:1888] found = 3
[test_util/src/lib.rs:1882] part = ")\ntest 6 ... ok ("
[test_util/src/lib.rs:1882] i = 7
[test_util/src/lib.rs:1888] "found " = "found "
[test_util/src/lib.rs:1888] found = 3
[test_util/src/lib.rs:1882] part = ")\ntest 7 ... ok ("
[test_util/src/lib.rs:1882] i = 8
[test_util/src/lib.rs:1888] "found " = "found "
[test_util/src/lib.rs:1888] found = 3
[test_util/src/lib.rs:1882] part = ")\ntest 8 ... ok ("
[test_util/src/lib.rs:1882] i = 9
[test_util/src/lib.rs:1888] "found " = "found "
[test_util/src/lib.rs:1888] found = 3
[test_util/src/lib.rs:1882] part = ")\ntest 9 ...\n------- output -------\nconsole.log\nconsole.error\n----- output end -----\ntest 9 ... ok ("
[test_util/src/lib.rs:1882] i = 10
[test_util/src/lib.rs:1891] "exit false " = "exit false "
[test_util/src/lib.rs:1891] i = 10
OUTPUT
Check file:https:///home/runner/work/deno/deno/cli/tests/testdata/test/pass.ts
running 10 tests from ./test/pass.ts
test 0 ... ok (6ms)
test 1 ... ok (4ms)
test 2 ... ok (3ms)
test 3 ... ok (2ms)
test 4 ... ok (2ms)
test 5 ... ok (3ms)
test 6 ... ok (3ms)
test 7 ... ok (2ms)
test 8 ... ok (4ms)
test 9 ...
------- output -------
console.error
console.log
error: test failed, to rerun pass '-p deno --test integration_tests'
----- output end -----
test 9 ... ok (3ms)

test result: ok. 10 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out (54ms)


OUTPUT
EXPECTED
Check [WILDCARD]/test/pass.ts
running 10 tests from ./test/pass.ts
test 0 ... ok ([WILDCARD])
test 1 ... ok ([WILDCARD])
test 2 ... ok ([WILDCARD])
test 3 ... ok ([WILDCARD])
test 4 ... ok ([WILDCARD])
test 5 ... ok ([WILDCARD])
test 6 ... ok ([WILDCARD])
test 7 ... ok ([WILDCARD])
test 8 ... ok ([WILDCARD])
test 9 ...
------- output -------
console.log
console.error
----- output end -----
test 9 ... ok ([WILDCARD])

test result: ok. 10 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out ([WILDCARD])


EXPECTED
thread 'integration::test::pass' panicked at 'pattern match failed', test_util/src/lib.rs:1842:7

https://github.com/denoland/deno/runs/6392374467?check_suite_focus=true

@dsherret dsherret added the flaky a test is not reliable or determinstic label May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flaky a test is not reliable or determinstic
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant