Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: deno doc panics on invalid url #11529

Closed
satyarohith opened this issue Jul 27, 2021 · 1 comment · Fixed by #11536
Closed

cli: deno doc panics on invalid url #11529

satyarohith opened this issue Jul 27, 2021 · 1 comment · Fixed by #11536
Labels
bug Something isn't working correctly cli related to cli/ dir

Comments

@satyarohith
Copy link
Member 

➜  ~ deno doc https://raw.githubusercontent.com%2Fdyedgreen%2Fdeno-sqlite%2Frework_api%2Fmod.ts\#PreparedQuery
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: InvalidUrl(InvalidDomainCharacter)', cli/tools/doc.rs:101:62
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
@satyarohith satyarohith added bug Something isn't working correctly cli related to cli/ dir labels Jul 27, 2021
@F3n67u F3n67u mentioned this issue Jul 27, 2021
Merged
@F3n67u
Copy link
Contributor

F3n67u commented Jul 27, 2021

Opened a pr to fix this panic, Could you help to review? @satyarohith

@ry ry closed this as completed in #11536 Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working correctly cli related to cli/ dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(cli): deno doc panics on invalid url F3n67u/deno
2 participants
@F3n67u @satyarohith