Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(json): convert XML to JSON #3

Merged
merged 33 commits into from
Mar 26, 2018
Merged

feat(json): convert XML to JSON #3

merged 33 commits into from
Mar 26, 2018

Conversation

gregswindle
Copy link
Member

@gregswindle gregswindle commented Mar 23, 2018 •
edited
Loading

git-pull-requestSubmit a pull request (PR)

Description of change(s)

Convert XML to JSON. This is an important feature for UX engineers, since JSON models are much easier to work with when using UI frameworks like Angular, React, and Vue.

Much of the documentation has been revised, too, in order to make govinfo-link-js more accessible to new consumers.

Associated issue(s)

Closes #1
Resolves #2
Resolves #5

Acceptance criteria/task completion

  • The acceptance criteria for all associated issues have been completed, tested, and validated.
  • All badges below show successful statuses.

checklist PR check-list

check Please verify and select ("check") each task/checkbox below.

1. Code standards compliance

JavaScript Style Guide

  • ESLint passes.

2. Code quality Quality Gate

  • All quality gateways pass.

    Apache License FOSSA Status NPM version
    NSP Status Dependency Status Development Dependency Status
    MacOS and Ubuntu build statuses Windows build status Coverage percentage Codacy code quality

3. Test coverage Coverage Status

  • The source code is 100% covered with passing specs.

info These tasks are not required to open a PR, and may be addressed while the PR is open.

@gregswindle
docs(apis): change API doc names
4310503
@gregswindle
docs(apis): clean up
6dc6202
@gregswindle
docs(apis): revise docs
aeb2c12
@gregswindle
chore(repo): replace all labels
fb22737
@gregswindle
test(coverage): add istanbul
61f3552 
Note that we're ignore most JavaScript since it was auto-generated.

#1
@gregswindle
test(coverage): fix lcov.info path
30f2517 
CPD the npm-script posttest:ci:coverage:codacy

#1
@gregswindle
docs(readme): add license
8c6ee67 
Fix badges
Modify Appveyor build
@gregswindle
docs(readme): add whitespace
540a842 
To slim-down the API Endpoints table.

#1
@gregswindle
docs(readme): add logo
c32e083 
Democracy IA, yo!

#1
@gregswindle gregswindle self-assigned this Mar 23, 2018
@gregswindle gregswindle added this to To do in API: govinfo link service via automation Mar 23, 2018
@gregswindle gregswindle moved this from To do to In progress in API: govinfo link service Mar 23, 2018
@gregswindle gregswindle changed the title feat(bills): convert bill XML to JSON feat(json): convert XML to JSON Mar 26, 2018
@gregswindle
Copy link
Member Author

Hi, @avloera and @JaseMiller,

Thanks for the ⭐️ s!

Any chance I could interest y'all in a PR? If not, totally cool.

@gregswindle gregswindle requested a review from a team March 26, 2018 04:22
@gregswindle
docs(readme): enumerate sections
a369346 
Also added--but did not enable--sonar-project.properties.

#1,#2,#3
@gregswindle
Merge branch 'feat/GH-1-xml2js' of https://github.com/democracy-ia/go…
e6de948 
…vinfo-link-js into feat/GH-1-xml2js
@gregswindle
style(docs): update markdown
a7675ea 
- Ensure all md pages had octicon-info image refs
- Update PR templates

#1,#2,#3
@gregswindle
style(templates): gussy-up PRs
a8abf57 
Add Octicons and badges.
@gregswindle
build(pkg): update dependencies
08025f4 
Package           Current  Wanted  Latest  Location         Package Type
ajv                 6.2.1   6.2.1   6.4.0  govinfo-link-js  devDependencies
codacy-coverage     2.1.0   2.1.0   2.1.1  govinfo-link-js  devDependencies
eslint             4.18.2  4.18.2  4.19.1  govinfo-link-js  devDependencies
insight            0.10.0  0.10.0  0.10.1  govinfo-link-js  dependencies
mocha               5.0.4   5.0.4   5.0.5  govinfo-link-js  devDependencies
semantic-release   15.0.2  15.0.2  15.1.4  govinfo-link-js  devDependencies

#1,#2,#3
@gregswindle
build(pkg): update dependencies
0933da0 
Package           Current  Wanted  Latest  Location         Package Type
ajv                 6.2.1   6.2.1   6.4.0  govinfo-link-js  devDependencies
codacy-coverage     2.1.0   2.1.0   2.1.1  govinfo-link-js  devDependencies
eslint             4.18.2  4.18.2  4.19.1  govinfo-link-js  devDependencies
insight            0.10.0  0.10.0  0.10.1  govinfo-link-js  dependencies
mocha               5.0.4   5.0.4   5.0.5  govinfo-link-js  devDependencies
semantic-release   15.0.2  15.0.2  15.1.4  govinfo-link-js  devDependencies
@gregswindle
Merge branch 'feat/GH-1-xml2js' of https://github.com/democracy-ia/go…
1446215 
…vinfo-link-js into feat/GH-1-xml2js
@gregswindle
docs(readme): fix API typo
11e5214 
#1,#2,#3
@gregswindle
docs(readme): add link-external indicator
36da1ca 
Also designate repo as an API project.

#1,#2,#3
@gregswindle
docs(apis): fix namespace typo
2bd849f 
#1,#2,#3
@gregswindle
docs(license): add Apache-2.0 doc
8efeff1 
#1,#2,#3
@gregswindle
docs(api): add link-external indicators
414f257 
#1,#2,#3
@gregswindle
docs(api): edit readme title and refs
e36a30f 
#1,#2,#3
@gregswindle
ci(compliance): enforce with Zappr
c85ef9e 
#1,#2,#3
@gregswindle gregswindle merged commit f79039a into master Mar 26, 2018
API: govinfo link service automation moved this from In progress to Done Mar 26, 2018
@gregswindle gregswindle deleted the feat/GH-1-xml2js branch March 26, 2018 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rknickme rknickme Awaiting requested review from rknickme

Assignees

@gregswindle gregswindle

Labels
priority: medium status: accepted type: feature type: test
Projects
API: govinfo link service
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@gregswindle