Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove CHANGELOG files from the repo #8716

Merged
merged 3 commits into from
Sep 1, 2020
Merged

remove CHANGELOG files from the repo #8716

merged 3 commits into from
Sep 1, 2020

Conversation

anara123
Copy link
Contributor

@anara123 anara123 commented Aug 29, 2020 •
edited
Loading

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

remove CHANGELOG files. We don't validate them anymore

Screenshots

Paste here any images that will help the reviewer

Minimum version of Demisto

  • 5.0.0
  • 5.5.0
  • 6.0.0

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

Must have

  • Tests
  • Documentation

yuvalbenshalom
yuvalbenshalom approved these changes Aug 30, 2020
View reviewed changes
Copy link
Contributor

@yuvalbenshalom yuvalbenshalom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a very practical review, but I did some checks and it looks ok

@anara123 anara123 merged commit 1fee2dc into master Sep 1, 2020
@anara123 anara123 deleted the remove-all-changelogs branch September 1, 2020 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuvalbenshalom yuvalbenshalom yuvalbenshalom approved these changes

Assignees
No one assigned
Labels
docs-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anara123 @yuvalbenshalom