Data Enrichment and Threat Intelligence and Authentication templates
#4462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kirbles19 need to review .yml files and python files. |
added 3 commits
September 23, 2019 13:17
Itay4
suggested changes
Sep 24, 2019
| return_error(err_msg, error=e) | ||
|
|
||
|
|
||
| if __name__ == '__builtin__': # pragma: no cover |
There was a problem hiding this comment.
whats the pragma comment here for ?
There was a problem hiding this comment.
for coverage that I run on the files.
I'm trying to add it to the circle also.
|
|
||
| def main(): # pragma: no cover | ||
| params = demisto.params() | ||
| base_url = params.get('url', '').rstrip('/') + '/api/v1' |
| return { | ||
| 'user': credentials.get('username'), | ||
| 'name': credentials.get('name'), | ||
| 'password': credentials.get('password'), |
| return { | ||
| 'Username': credentials.get('username'), | ||
| 'Name': credentials.get('name'), | ||
| 'IsLocked': credentials.get('isLocked'), |
There was a problem hiding this comment.
| return_error(err_msg, error=e) | ||
|
|
||
|
|
||
| if __name__ == '__builtin__': # pragma: no cover |
There was a problem hiding this comment.
Suggested change
| if __name__ == '__builtin__': # pragma: no cover | |
| if __name__ == 'builtins': # pragma: no cover |
| name: url | ||
| required: true | ||
| type: 0 | ||
| - defaultvalue: 'true' |
Templates/Integrations/DataEnrichmentThreatIntelligence/DataEnrichmentThreatIntelligence.yml
Show resolved
Hide resolved
| name: insecure | ||
| required: false | ||
| type: 8 | ||
| - display: Use system proxy |
There was a problem hiding this comment.
Suggested change
| - display: Use system proxy | |
| - display: Use system proxy settings |
| required: true | ||
| type: 0 | ||
| - defaultvalue: 'true' | ||
| display: Trust any certificate (insecure) |
There was a problem hiding this comment.
Suggested change
| display: Trust any certificate (insecure) | |
| display: Trust any certificate (not secure) |
added 11 commits
October 7, 2019 11:51
# Conflicts: # Tests/secrets_white_list.json
Itay4
approved these changes
Oct 17, 2019
yaakovi
approved these changes
Oct 17, 2019
| from typing import Dict, Tuple, Optional, List, Union | ||
| import urllib3 | ||
|
|
||
| # Disable insecure warnings |
There was a problem hiding this comment.
this should be in CommonServerPython (next to the requests import.
|
|
||
|
|
||
| class Client(BaseClient): | ||
| def __init__(self, base_url, threshold: int = 70, *args, **kwargs): |
There was a problem hiding this comment.
Suggested change
| def __init__(self, base_url, threshold: int = 70, *args, **kwargs): | |
| def __init__(self, base_url, threshold: int = DEFAULT_THRESHOLD, *args, **kwargs): |
| """ | ||
| if isinstance(results, list): | ||
| return [build_entry_context(entry, indicator_type) for entry in results] # pragma: no cover | ||
| return { |
There was a problem hiding this comment.
add blank line after condition block
| raw_response = client.get_domain(url) | ||
| results = raw_response.get('result') | ||
| if results: | ||
| result = results[0] |
There was a problem hiding this comment.
because the api will return one result per call with 1 domain.
and added argument descriptions to two arguments.
|
@jochman Done reviewing both YMLs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready
Description
New
Data Enrichment and Threat IntelligenceandAuthenticationtemplates.Does it break backward compatibility?
Must have
Technical writer review
Mention and link to the files that require a technical writer review.
Authentication
DETI