Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the OS keyring to store the token #212

Open
dLobatog opened this issue Sep 23, 2015 · 1 comment
Open

Use the OS keyring to store the token #212

dLobatog opened this issue Sep 23, 2015 · 1 comment

Comments

@dLobatog
Copy link

Having the access token as a plaintext file is a bit of a risk I'd like to avoid, but I can't. I think using Seahorse or OSX keychains would be a better default for supported OSs.

https://github.com/jheiss/keyring provides an interface to these keyrings we could use to store the tokens in a more secure manner. Would this be a patch you'd accept if I code it up?

@ConradIrwin
Copy link
Collaborator

Hey @elobato, I'd love to. Two things to bear in mind while working on this:

  1. Preserve backward compatibility for people with the existing setup.
  2. We publish gist as a standalone ruby script in homebrew, so we can't load any dependencies at runtime. I.e. it's almost certainly easier to inline the necessary bits of code than to depend on the library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants