fix: Fix deserialization of pipelines that contain LLMEvaluator subclasses
#7891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
topic:tests
type:documentation
shadeMe
force-pushed
the
fix/llm-evaluator-subclass-serde
branch
from
92c9856
to
86ca7b9
Compare
shadeMe
requested review from
dfokina,
vblagoje and
davidsbatista
and removed request for
a team
Pull Request Test Coverage Report for Build 9580972165Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9581003751Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9581203383Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
@componentdecorator on a class that inherits from another marked with the same breaks its init #7824FaithfulnesEvaluatorandContextRelevanceEvaluatorcannot be loaded viaPipeline.from_dict#7884Proposed Changes:
The subclass of the
LLMEvaluatorcomponent were not using the@componentdecorator, which prevented them from being added to the internal component registry. This caused a failure when deserializing a pipeline that contained on those components. Furthermore, both subclasses were missingto_dictmethods, which lead to the wrong base class method being invoked resulting in yet another failure.How did you test it?
Unit tests
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.