-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify existing chat + RAG cookbook to include previous user chat messages #7868
Comments
For context: deepset-ai/haystack-cookbook#90 This is the PR that we were about to merge in the cookbooks repo. But we didn't because of the user messages not being saved in memory. |
@vblagoje Let's talk about this issue when you start working on it. |
For increased visibility: @annthurium @TuanaCelik I have updated the proposed notebook to include user's questions. The main change is the direct question injection into OutputAdapter which in turn saves both question and answer (we already saved that one). I adjusted prompt a bit and used gpt-4 to get fewer "wrong" answers. I suggest to devrel team to take the notebook referenced above, run it yourself, adjust it where needed (perhaps reduce verbosity etc) and LMK if there is anything else needed for it. |
@vblagoje - thanks for creating this. However this leaves me with the question about the output adaptor. I thought there was some work by you and @julian-risch to remove the output adaptor? In this scenario we need to have it in here because it's the only way we have the user messages correct? |
May I suggest a solution similar to this: https://colab.research.google.com/drive/1kJqMWRrP96YoXek6WIZNlnh-fW1fRvKe?usp=sharing This means users do not have to worry about output adapters etc as it's all wrapped up in a |
Can we also close this one @julian-risch ? |
Yes, closed by deepset-ai/haystack-cookbook#110 |
Modify the demo colab to support memory for user messages.
The text was updated successfully, but these errors were encountered: