Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check for None in SAS eval input #7909

Merged
merged 2 commits into from
Jun 21, 2024
Merged

fix: check for None in SAS eval input #7909

merged 2 commits into from
Jun 21, 2024

Conversation

lbux
Copy link
Contributor

@lbux lbux commented Jun 21, 2024

Related Issues

Proposed Changes:

Properly raises ValueError if any input in input list for predicted_answers contains None.

How did you test it?

Checked for Value Error raise.

Notes for the reviewer

N/A

Checklist

@lbux lbux requested review from a team as code owners June 21, 2024 01:43
@lbux lbux requested review from dfokina and Amnah199 and removed request for a team June 21, 2024 01:43
@coveralls
Copy link
Collaborator

coveralls commented Jun 21, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9606948606

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 8 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.002%) to 90.173%
Files with Coverage Reduction New Missed Lines %
components/evaluators/sas_evaluator.py 8 63.33%
Totals Coverage Status
Change from base Build 9600865720: 0.002%
Covered Lines: 7020
Relevant Lines: 7785
💛 - Coveralls

@github-actions github-actions bot added the type:documentation Improvements on the docs label Jun 21, 2024
@coveralls
Copy link
Collaborator

coveralls commented Jun 21, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9612305431

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 81 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.2%) to 89.98%
Files with Coverage Reduction New Missed Lines %
document_stores/in_memory/document_store.py 1 97.87%
core/component/component.py 2 98.28%
components/evaluators/sas_evaluator.py 8 63.33%
utils/hf.py 20 83.89%
components/validators/json_schema.py 50 0.0%
Totals Coverage Status
Change from base Build 9600865720: -0.2%
Covered Lines: 6717
Relevant Lines: 7465
💛 - Coveralls

davidsbatista
davidsbatista approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@davidsbatista davidsbatista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a small comment on the release note other than that LGTM, thanks for contributing!

@davidsbatista davidsbatista merged commit 9c45203 into deepset-ai:main Jun 21, 2024
17 checks passed
@lbux lbux deleted the handle-None-in-evals branch June 21, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Amnah199 Amnah199 Amnah199 approved these changes

@davidsbatista davidsbatista davidsbatista approved these changes

@dfokina dfokina Awaiting requested review from dfokina dfokina is a code owner automatically assigned from deepset-ai/documentation

Assignees
No one assigned
Labels
topic:tests type:documentation Improvements on the docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SASEvaluator returns score even when predicted_answers contains None
4 participants
@lbux @coveralls @davidsbatista @Amnah199