Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add PPTXToDocument converter #7808

Merged
merged 8 commits into from
Jun 7, 2024
Merged

feat: Add PPTXToDocument converter #7808

merged 8 commits into from
Jun 7, 2024

Conversation

sjrl
Copy link
Contributor

@sjrl sjrl commented Jun 5, 2024 •
edited
Loading

Related Issues

Proposed Changes:

Add a PPTXToDocument converter to convert PPTX files to Haystack Document files.

How did you test it?

Added unit and integration tests

Notes for the reviewer

Checklist

@coveralls
Copy link
Collaborator

coveralls commented Jun 5, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9385021091

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 89.743%
Totals Coverage Status
Change from base Build 9382709167: 0.02%
Covered Lines: 6763
Relevant Lines: 7536
💛 - Coveralls

@sjrl sjrl marked this pull request as ready for review June 5, 2024 13:38
@sjrl sjrl requested review from a team as code owners June 5, 2024 13:38
@sjrl sjrl requested review from dfokina and Amnah199 and removed request for a team June 5, 2024 13:38
@coveralls
Copy link
Collaborator

coveralls commented Jun 5, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9385175311

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 89.787%
Totals Coverage Status
Change from base Build 9385039656: 0.06%
Covered Lines: 6813
Relevant Lines: 7588
💛 - Coveralls

@coveralls
Copy link
Collaborator

coveralls commented Jun 5, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9385179301

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 89.787%
Totals Coverage Status
Change from base Build 9385039656: 0.06%
Covered Lines: 6813
Relevant Lines: 7588
💛 - Coveralls

@coveralls
Copy link
Collaborator

coveralls commented Jun 5, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9385188665

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 89.787%
Totals Coverage Status
Change from base Build 9385039656: 0.06%
Covered Lines: 6813
Relevant Lines: 7588
💛 - Coveralls

@sjrl sjrl requested a review from silvanocerza June 6, 2024 07:48
@coveralls
Copy link
Collaborator

coveralls commented Jun 6, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9397968576

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 89.791%
Totals Coverage Status
Change from base Build 9387490162: 0.06%
Covered Lines: 6816
Relevant Lines: 7591
💛 - Coveralls

silvanocerza
silvanocerza approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@silvanocerza silvanocerza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@silvanocerza
Copy link
Contributor

Rebased to fix conflicts in pyproject.toml.

@silvanocerza silvanocerza enabled auto-merge (squash) June 7, 2024 09:23
@coveralls
Copy link
Collaborator

coveralls commented Jun 7, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9414745173

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 89.75%
Totals Coverage Status
Change from base Build 9402214223: 0.06%
Covered Lines: 6821
Relevant Lines: 7600
💛 - Coveralls

@silvanocerza silvanocerza merged commit 2c2c7c9 into main Jun 7, 2024
24 checks passed
@silvanocerza silvanocerza deleted the pptx-converter branch June 7, 2024 09:43
@sjrl sjrl mentioned this pull request Jun 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silvanocerza silvanocerza silvanocerza approved these changes

@dfokina dfokina Awaiting requested review from dfokina dfokina is a code owner automatically assigned from deepset-ai/documentation

@Amnah199 Amnah199 Awaiting requested review from Amnah199 Amnah199 is a code owner automatically assigned from deepset-ai/open-source-engineering

Assignees
No one assigned
Labels
topic:build/distribution topic:tests type:documentation Improvements on the docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Port PptxToDocument converter from Haystack v1
3 participants
@sjrl @coveralls @silvanocerza