Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hybrid doc search e2e fails with DuplicateDocumentError #7788

Closed
julian-risch opened this issue Jun 3, 2024 · 0 comments · Fixed by #7792
Closed

Hybrid doc search e2e fails with DuplicateDocumentError #7788

julian-risch opened this issue Jun 3, 2024 · 0 comments · Fixed by #7792
Assignees

Comments

@julian-risch
Copy link
Member

Here is the test run https://github.com/deepset-ai/haystack/actions/runs/9342231146/job/25710027363
which fails with a DuplicteDocumentError.

We are calling write_documents twice, writing documents with the same content once without embeddings and once with embeddings:

hybrid_pipeline.get_component("bm25_retriever").document_store.write_documents(documents)
        doc_embedder = SentenceTransformersDocumentEmbedder(model="sentence-transformers/all-MiniLM-L6-v2")
        doc_embedder.warm_up()
        embedded_documents = doc_embedder.run(documents=documents)["documents"]
>       hybrid_pipeline.get_component("embedding_retriever").document_store.write_documents(embedded_documents)

The error occurs since we merged feat: Add memory sharing between different instances of InMemoryDocumentStore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants