You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
The workflow minor_version_release has the following responsibilities:
Create the release branch for minor versions, e.g. 2.2.x
Bump the version number in VERSION.txt in main
Tag main with a special tag with the format <next.release-rc0>, e.g. 2.3.0-rc0
At the moment the workflow tags the main branch at the same commit where we branch off the minor release. This confuses reno that will generate wrong release notes from the version branch.
Expected behavior
The -rc0 tag should be applied to the subsequent commit after we branch out the release branch. For example
Unfortunately, the fix isn't trivial as it'll involve splitting the workflow into another and trigger in on specific PRs. Furthermore, it'll only be a band-aid over the complicated release process - time would be better served to simplify/refactor the latter (in the direction of the workflow we have for core integrations).
Describe the bug
The workflow minor_version_release has the following responsibilities:
2.2.x
VERSION.txt
inmain
main
with a special tag with the format <next.release-rc0>, e.g.2.3.0-rc0
At the moment the workflow tags the
main
branch at the same commit where we branch off the minor release. This confusesreno
that will generate wrong release notes from the version branch.Expected behavior
The
-rc0
tag should be applied to the subsequent commit after we branch out the release branch. For exampleAdditional context
Since the workflow creates a PR to update
VERSION.txt
, we should find a way to tag themain
branch AFTER that PR is merged.The text was updated successfully, but these errors were encountered: