Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Version Release workflow: rc0 tag wrongly placed #7783

Open
masci opened this issue May 31, 2024 · 1 comment
Open

Minor Version Release workflow: rc0 tag wrongly placed #7783

masci opened this issue May 31, 2024 · 1 comment
Labels
P3 Low priority, leave it in the backlog

Comments

@masci
Copy link
Contributor

masci commented May 31, 2024

Describe the bug
The workflow minor_version_release has the following responsibilities:

  1. Create the release branch for minor versions, e.g. 2.2.x
  2. Bump the version number in VERSION.txt in main
  3. Tag main with a special tag with the format <next.release-rc0>, e.g. 2.3.0-rc0

At the moment the workflow tags the main branch at the same commit where we branch off the minor release. This confuses reno that will generate wrong release notes from the version branch.

Expected behavior
The -rc0 tag should be applied to the subsequent commit after we branch out the release branch. For example

<main> (TAG: 2.3.0-rc0)
c3
 |
c2 --- c4 - c5 <2.2.x>
 |
c1

Additional context
Since the workflow creates a PR to update VERSION.txt, we should find a way to tag the main branch AFTER that PR is merged.

@masci masci added this to the 2.3.0 milestone Jun 3, 2024
@masci masci added the P2 Medium priority, add to the next sprint if no P1 available label Jun 3, 2024
@shadeMe shadeMe self-assigned this Jun 10, 2024
@mrm1001 mrm1001 added P1 High priority, add to the next sprint and removed P2 Medium priority, add to the next sprint if no P1 available labels Jun 21, 2024
@shadeMe
Copy link
Collaborator

shadeMe commented Jul 5, 2024

Unfortunately, the fix isn't trivial as it'll involve splitting the workflow into another and trigger in on specific PRs. Furthermore, it'll only be a band-aid over the complicated release process - time would be better served to simplify/refactor the latter (in the direction of the workflow we have for core integrations).

Moving it back to the backlog.

@shadeMe shadeMe removed this from the 2.3.0 milestone Jul 5, 2024
@shadeMe shadeMe added P3 Low priority, leave it in the backlog and removed P1 High priority, add to the next sprint labels Jul 5, 2024
@shadeMe shadeMe removed their assignment Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 Low priority, leave it in the backlog
Projects
None yet
Development

No branches or pull requests

3 participants