feat: Add TransformersTextRouter component
#7801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjrl
requested review from
dfokina and
julian-risch
and removed request for
a team
Pull Request Test Coverage Report for Build 9384370171Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
sjrl
commented
Jun 4, 2024
|
Hey @julian-risch this is ready for review! |
julian-risch
requested changes
Jun 5, 2024
There was a problem hiding this comment.
Looks quite good to me already. I only have some minor comments and a question about the from_dict. The new component also needs to be added to docs/pydoc/config/routers_api.yml
Great that you asked about the warm_up before on Slack! 👍
Could you please sync with @dfokina regarding a documentation web page about this new component?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
TransformersTextRouterbased on HF TextClassification pipeline #7753Proposed Changes:
How did you test it?
Added unit tests and an integration test
Notes for the reviewer
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.