Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: PyPDFToDocument - remove deprecated converter_name and CONVERTERS_REGISTRY #7910

Merged
merged 2 commits into from
Jun 21, 2024
Merged

chore: PyPDFToDocument - remove deprecated converter_name and CONVERTERS_REGISTRY #7910

merged 2 commits into from
Jun 21, 2024

Conversation

anakin87
Copy link
Member

Related Issues

Proposed Changes:

As previously announced, remove converter_name init parameter and internal CONVERTERS_REGISTRY

How did you test it?

CI

Checklist

@github-actions github-actions bot added topic:tests type:documentation Improvements on the docs labels Jun 21, 2024
@coveralls
Copy link
Collaborator

coveralls commented Jun 21, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9613049710

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 89.957%
Files with Coverage Reduction New Missed Lines %
components/converters/pypdf.py 6 90.0%
Totals Coverage Status
Change from base Build 9612234117: -0.02%
Covered Lines: 6700
Relevant Lines: 7448
💛 - Coveralls

@coveralls
Copy link
Collaborator

coveralls commented Jun 21, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9613098651

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 89.957%
Files with Coverage Reduction New Missed Lines %
components/converters/pypdf.py 6 90.0%
Totals Coverage Status
Change from base Build 9612234117: -0.02%
Covered Lines: 6700
Relevant Lines: 7448
💛 - Coveralls

@anakin87 anakin87 marked this pull request as ready for review June 21, 2024 12:48
@anakin87 anakin87 requested review from a team as code owners June 21, 2024 12:48
@anakin87 anakin87 requested review from dfokina and Amnah199 and removed request for a team June 21, 2024 12:48
@coveralls
Copy link
Collaborator

coveralls commented Jun 21, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9613862726

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 14 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 89.96%
Files with Coverage Reduction New Missed Lines %
components/converters/pypdf.py 6 90.0%
components/evaluators/sas_evaluator.py 8 63.33%
Totals Coverage Status
Change from base Build 9612234117: -0.02%
Covered Lines: 6702
Relevant Lines: 7450
💛 - Coveralls

Amnah199
Amnah199 approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@Amnah199 Amnah199 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good.

@Amnah199 Amnah199 merged commit c51f8ff into main Jun 21, 2024
30 checks passed
@Amnah199 Amnah199 deleted the pypdf-rm-deprecated-params branch June 21, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Amnah199 Amnah199 Amnah199 approved these changes

@dfokina dfokina Awaiting requested review from dfokina dfokina is a code owner automatically assigned from deepset-ai/documentation

Assignees
No one assigned
Labels
topic:tests type:documentation Improvements on the docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PyPDFToDocument: remove deprecated converter_name and CONVERTERS_REGISTRY
3 participants
@anakin87 @coveralls @Amnah199