Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: AnswerExactMatchEvaluator component inputs #7536

Merged
merged 5 commits into from
Apr 12, 2024
Merged

refactor: AnswerExactMatchEvaluator component inputs #7536

merged 5 commits into from
Apr 12, 2024

Conversation

masci
Copy link
Contributor

@masci masci commented Apr 11, 2024

Related Issues

Proposed Changes:

Change the component inputs as described in the attached issue

How did you test it?

Notes for the reviewer

Checklist

@github-actions github-actions bot added topic:tests 2.x Related to Haystack v2.0 type:documentation Improvements on the docs labels Apr 11, 2024
@masci masci requested a review from julian-risch April 11, 2024 16:28
@coveralls
Copy link
Collaborator

coveralls commented Apr 11, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8658195269

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 33 unchanged lines in 6 files lost coverage.
  • Overall coverage increased (+0.1%) to 90.063%
Files with Coverage Reduction New Missed Lines %
core/serialization.py 2 95.83%
core/pipeline/descriptions.py 3 54.55%
core/component/sockets.py 4 85.71%
telemetry/_environment.py 6 84.21%
logging.py 7 93.16%
core/pipeline/pipeline.py 11 94.05%
Totals Coverage Status
Change from base Build 8648609512: 0.1%
Covered Lines: 6254
Relevant Lines: 6944
💛 - Coveralls

@masci masci requested a review from a team as a code owner April 11, 2024 16:41
@masci masci requested review from dfokina and removed request for a team April 11, 2024 16:41
@masci masci requested a review from a team as a code owner April 11, 2024 18:09
@masci masci requested review from vblagoje and removed request for a team April 11, 2024 18:09
julian-risch
julian-risch approved these changes Apr 11, 2024
View reviewed changes
Copy link
Member

@julian-risch julian-risch left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍 I just updated the docstring. It still referred to the old logic.
The release note looks great! We didn't include evaluation features in any earlier release. That's why I don't see a need to include the upgrade steps in the release notes of Haystack 2.1.0. In this particular case, it would be better to update this note instead: https://github.com/deepset-ai/haystack/blob/main/releasenotes/notes/exact-match-evaluator-197bb87b65e19d0c.yaml

@julian-risch julian-risch removed the request for review from vblagoje April 11, 2024 18:14
@julian-risch julian-risch changed the title refact: AnswerExactMatchEvaluator component inputs refactor: AnswerExactMatchEvaluator component inputs Apr 11, 2024
@julian-risch
Copy link
Member

@dfokina The draft of the documentation page is already up to date with the changes made in this PR.

@masci masci enabled auto-merge (squash) April 12, 2024 06:57
@masci masci merged commit 2bad5bc into main Apr 12, 2024
15 checks passed
@masci masci deleted the massi/7459 branch April 12, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julian-risch julian-risch julian-risch approved these changes

@dfokina dfokina Awaiting requested review from dfokina dfokina is a code owner automatically assigned from deepset-ai/documentation

Assignees
No one assigned
Labels
2.x Related to Haystack v2.0 topic:tests type:documentation Improvements on the docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: AnswerExactMatchEvaluator input should be one answer per query instead of list of answers
3 participants
@masci @coveralls @julian-risch