fix: make PromptBuilder input parameters mandatory #7442
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Pull Request Test Coverage Report for Build 8490134263Details
💛 - Coveralls |
|
Thanks for the PR! Would you mind adding a release note as well? |
Thanks for the reply. Sure, I can add a release note to this, but I believe the issue still needs further discussion and we might need to change the implementation accordingly to avoid potential breaking changes (see #7441). |
LastRemote
changed the title
|
Closing this PR in favor of #7553 |
LastRemote
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
Make {'is_mandatory': True} for all PromptBuilder inputs. PromptBuilder will now check the input variables during pipeline runs and throw ValueError if some of the template variables found in jinja templates are missing.
How did you test it?
Tested by following the 2.0 RAG pipeline recipe from https://docs.haystack.deepset.ai/docs/creating-pipelines
Notes for the reviewer
Not sure if this needs a new unit test for a small change like this, but I can definitely go add one if necessary.
An additional question would be if PromptBuilder.run() should check these parameters as well. I decided to leave it alone since this willwould alter the behavior in test.components.builders.test_run_without_input(), but it makes sense either way.
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.