Changing of loglevel during update_embeddings is misleading

[laffeychris]

Describe the bug
The line here logging.getLogger(__name__).setLevel(logging.CRITICAL) changes the log level from INFO to CRITICAL.
This leads to the first call to update_embeddings being logged, (e.g. "Updating embeddings for all 1 docs without embeddings.."), but all subsequent calls to update_embeddings are not logged.

This is quite misleading, and I assumed there was a bug in the code where my embeddings were not being updated, leading me to spend a few hours investigating.

Expected behavior
Principal of least surprise - don't change log levels as part of a standard function call. We should be able to see these logs on all subsequent calls to update_embeddings, not just the first.

Can we just remove this call to logging.getLogger(__name__).setLevel(logging.CRITICAL) which changes the log level? Why are we doing this in the first place?

Thanks in advance!

To Reproduce

1. Call update_embeddings
2. Call it again

FAQ Check

• Have you had a look at our new FAQ page?

System:

• OS: mac
• GPU/CPU: gpu
• Haystack version (commit or version number): 1.22.1
• DocumentStore: ElasticSearch/Opensearch
• Reader: N/A
• Retriever: N/A