Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load/Dump pipelines in Yaml format #6010

Closed
Timoeller opened this issue Oct 9, 2023 · 2 comments · Fixed by #6137
Closed

Load/Dump pipelines in Yaml format #6010

Timoeller opened this issue Oct 9, 2023 · 2 comments · Fixed by #6137
Assignees
@masci
Labels
2.x Related to Haystack v2.0 P1 High priority, add to the next sprint
Milestone
2.0-beta

Comments

@Timoeller
Copy link
Contributor

Timoeller commented Oct 9, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe.
We need the JSON or YAML representation to define pipelines.

Update:
We need example code or end2end tests for going from a pipeline JSON to an executable pipeline and vice versa.
@Timoeller Timoeller added P1 High priority, add to the next sprint 2.x Related to Haystack v2.0 labels Oct 9, 2023
@Timoeller Timoeller added this to the 2.0-beta milestone Oct 9, 2023
@ZanSara
Copy link
Contributor

ZanSara commented Oct 9, 2023

Just FYI: Pipelines right now have a to_dict (https://github.com/deepset-ai/canals/blob/d6f0cbec28871025992e962ebb18fb9451f2b0c3/canals/pipeline/pipeline.py#L83) and from_dict (https://github.com/deepset-ai/canals/blob/d6f0cbec28871025992e962ebb18fb9451f2b0c3/canals/pipeline/pipeline.py#L109) methods.

@Timoeller
Copy link
Contributor Author

OK thanks. That means we have all the necessary underlying functionality already in place? I added an update to the issue description, because we need to showcase this functionality.

@masci masci self-assigned this Oct 16, 2023
@masci masci mentioned this issue Oct 20, 2023
Merged
@masci masci changed the title pipeline 2.0 JSON format Load/Save pipelines in Yaml format Oct 20, 2023
@masci masci changed the title Load/Save pipelines in Yaml format Load/Dump pipelines in Yaml format Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@masci masci

Labels
2.x Related to Haystack v2.0 P1 High priority, add to the next sprint
Projects
None yet
Milestone
2.0-beta
Development

Successfully merging a pull request may close this issue.

feat: add pipeline Yaml marshaller deepset-ai/haystack
3 participants
@masci @Timoeller @ZanSara