Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

self correction loop for json parser #5989

Closed
Timoeller opened this issue Oct 6, 2023 · 2 comments · Fixed by #6418
Closed

self correction loop for json parser #5989

Timoeller opened this issue Oct 6, 2023 · 2 comments · Fixed by #6418
Assignees
Labels
2.x Related to Haystack v2.0 P2 Medium priority, add to the next sprint if no P1 available type:feature New feature or request
Milestone

Comments

@Timoeller
Copy link
Contributor

Enable deepset-ai/haystack-demos#23 within haystack natively.
In the PR description there are 2 todos left open to fully enable this feature in haystack:

  1. We need optional variables in PromptTemplates (we are using a haystack branch so far)
  2. Allow three variables in the prompt template so that we can include the error message (so far only the wrongly generated output is used)

Additional context
This feature is important to showcase haystack 2.0 new feature around loops within pipelines

@Timoeller Timoeller added type:feature New feature or request 2.x Related to Haystack v2.0 labels Oct 6, 2023
@Timoeller Timoeller added this to the 2.0-beta milestone Oct 6, 2023
@Timoeller Timoeller added P2 Medium priority, add to the next sprint if no P1 available P3 Low priority, leave it in the backlog and removed P2 Medium priority, add to the next sprint if no P1 available P3 Low priority, leave it in the backlog labels Oct 9, 2023
@tholor
Copy link
Member

tholor commented Oct 18, 2023

We need optional variables in PromptTemplates (we are using a haystack branch so far)

To add some context here: In the hackathon for the demo, we simply
changed this line to
component.set_input_types(self, **{var: Optional[Any] for var in template_variables}) to enable one optional input (replies). However, this somehow didn't work with a second optional input we wanted (error_msg).

@tholor
Copy link
Member

tholor commented Nov 20, 2023

blocked by #6356

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Related to Haystack v2.0 P2 Medium priority, add to the next sprint if no P1 available type:feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants