Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: readme-get-started #5993

Merged
merged 4 commits into from
Oct 9, 2023
Merged

docs: readme-get-started #5993

merged 4 commits into from
Oct 9, 2023

Conversation

dfokina
Copy link
Contributor

@dfokina dfokina commented Oct 6, 2023

Related Issues

Proposed Changes:

  • Added a quick get started code to Haystack readme.md

How did you test it?

Notes for the reviewer

Checklist

@dfokina dfokina requested review from a team as code owners October 6, 2023 14:07
@dfokina dfokina requested review from ZanSara and removed request for a team October 6, 2023 14:07
@dfokina
Copy link
Contributor Author

dfokina commented Oct 6, 2023

FYI @Timoeller @bilgeyucel

bilgeyucel
bilgeyucel approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@bilgeyucel bilgeyucel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a small comment to make it more aligned with the quick start page

README.md Outdated Show resolved Hide resolved
@dfokina @bilgeyucel
lg update
fd0563b 
Co-authored-by: Bilge Yücel <[email protected]>
@dfokina dfokina merged commit d0ff3fa into main Oct 9, 2023
7 checks passed
@dfokina dfokina deleted the readme-get-started branch October 9, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bilgeyucel bilgeyucel bilgeyucel approved these changes

@ZanSara ZanSara ZanSara approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add getting started code to our docs and GitHub readme
3 participants
@dfokina @ZanSara @bilgeyucel