Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: OpenSearchDocumentStore.delete_index doesn't raise #4295

Merged
merged 1 commit into from
Mar 1, 2023
Merged

fix: OpenSearchDocumentStore.delete_index doesn't raise #4295

merged 1 commit into from
Mar 1, 2023

Conversation

tstadel
Copy link
Member

@tstadel tstadel commented Feb 28, 2023

Related Issues

Proposed Changes:

  • check if index exists before IVF cleanup

How did you test it?

  • added test

Notes for the reviewer

Checklist

  • I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added tests that demonstrate the correct behavior of the change
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test:.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

@tstadel tstadel requested a review from a team as a code owner February 28, 2023 15:09
@tstadel tstadel requested review from masci and removed request for a team February 28, 2023 15:09
masci
masci approved these changes Mar 1, 2023
View reviewed changes
Copy link
Contributor

@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@masci masci merged commit d1c9407 into main Mar 1, 2023
@masci masci deleted the fix/opensearch_delete_index branch March 1, 2023 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masci masci masci approved these changes

Assignees
No one assigned
Labels
topic:document_store topic:opensearch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OpenSearchDocumentStore.delete_index breaks if index does not exist
2 participants
@tstadel @masci