We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe the bug Starting with 1.13.0, BaseReader.run does not deduplicate documents in isolated node eval.
BaseReader.run
Previously we used
relevant_documents = {label.document.id: label.document for label in labels.labels}.values()
which deduplicates documents in case there are labels for the same documents (but different span).
Now we don't do this anymore:
haystack/haystack/nodes/reader/base.py
Lines 120 to 122 in a2c160e
This results in duplicate predictions as the Reader treats the same documents as different ones.
Error message None, but duplicate predictions.
Expected behavior No duplicate predictions.
To Reproduce
add_isolated_node_eval=True
FAQ Check
System:
The text was updated successfully, but these errors were encountered:
bogdankostic
Successfully merging a pull request may close this issue.
Describe the bug
Starting with 1.13.0,
BaseReader.run
does not deduplicate documents in isolated node eval.Previously we used
which deduplicates documents in case there are labels for the same documents (but different span).
Now we don't do this anymore:
haystack/haystack/nodes/reader/base.py
Lines 120 to 122 in a2c160e
This results in duplicate predictions as the Reader treats the same documents as different ones.
Error message
None, but duplicate predictions.
Expected behavior
No duplicate predictions.
Additional context
To Reproduce
add_isolated_node_eval=True
.FAQ Check
System:
The text was updated successfully, but these errors were encountered: