Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix torchaudio version #4102

Merged
merged 4 commits into from
Feb 9, 2023
Merged

fix: fix torchaudio version #4102

merged 4 commits into from
Feb 9, 2023

Conversation

mayankjobanputra
Copy link
Contributor

@mayankjobanputra mayankjobanputra commented Feb 8, 2023 •
edited

Related Issues

Proposed Changes:

Removed torchaudio dependency after confirming it will work with dC.

How did you test it?

Have not but as mentioned, confirmed with dC.

Notes for the reviewer

Checklist

  • I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added tests that demonstrate the correct behavior of the change
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test:.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

@mayankjobanputra mayankjobanputra marked this pull request as ready for review February 9, 2023 09:30
@mayankjobanputra mayankjobanputra requested a review from a team as a code owner February 9, 2023 09:30
@mayankjobanputra mayankjobanputra requested review from masci and removed request for a team February 9, 2023 09:30
@mayankjobanputra mayankjobanputra added this to the 1.13.2 milestone Feb 9, 2023
masci
masci approved these changes Feb 9, 2023
View reviewed changes
Copy link
Contributor

@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mayankjobanputra mayankjobanputra merged commit 93962c0 into main Feb 9, 2023
@mayankjobanputra mayankjobanputra deleted the mayank/torchaudio_dockerfix branch February 9, 2023 09:44
ZanSara pushed a commit that referenced this pull request Feb 9, 2023
@mayankjobanputra @ZanSara
fix: fix torchaudio version (#4102)
38dcd95 
* fix torchaudio version

* added comment for keeping torchaudio last

* removed torchaudio from base
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masci masci masci approved these changes

Assignees
No one assigned
Labels
topic:docker
Projects
None yet
Milestone
1.13.2
Development

Successfully merging this pull request may close these issues.

Wrong torchaudio version is installed into docker images
2 participants
@mayankjobanputra @masci