Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade torch to 1.13.0 #3683

Closed
julian-risch opened this issue Dec 8, 2022 · 5 comments · Fixed by #3727
Closed

Upgrade torch to 1.13.0 #3683

julian-risch opened this issue Dec 8, 2022 · 5 comments · Fixed by #3727
Labels
P2 Medium priority, add to the next sprint if no P1 available

Comments

@julian-risch
Copy link
Member

julian-risch commented Dec 8, 2022

**Describe the issue
Let's upgrade to torch 1.13.0 (and to 1.13.1 as soon as it is released) to prepare for speed improvements coming with version 2.0.
Colab notebooks also have version 1.13.0 pre-installed now.

@mayankjobanputra tracked changes between 1.13.1 and 2.0. It seems that the changes from there aren't big. If we upgrade to 1.13 now it will hopefully allow us to make the jump to 2.0 quickly.

**Additional context
Add any other context about the problem here.

@julian-risch julian-risch added the P2 Medium priority, add to the next sprint if no P1 available label Dec 8, 2022
@julian-risch
Copy link
Member Author

by Mayank: In case someone is interested in reading further about torch-2.0 and torch-1.13,
Here is nice FAQ: https://pytorch.org/get-started/pytorch-2.0/#faqs

@mayankjobanputra
Copy link
Contributor

huggingface/transformers#20168 This is how hf-transformers solved their issue. Seems a bit untidy solution for us. But still investigating.

@sjrl
Copy link
Contributor

sjrl commented Dec 12, 2022

Just to throw my two cents here. We would like to not to temporarily drop support for TAPAS models since we are actively developing a German version to use for clients. The TAPAS models are used for the TableReader.

@mayankjobanputra
Copy link
Contributor

@sjrl pointed me to this solution for getting rid of torch-scatter dependency. huggingface/transformers#20101

@julian-risch this is on the similar line we discussed! Hopefully next release we will be able to upgrade the torch to 1.13

@sjrl
Copy link
Contributor

sjrl commented Dec 13, 2022

I've opened this PR #3703 bumping the transformers version which allows us to remove torch-scatter as a dependency for Haystack. This should hopefully help us be able to bump to Pytorch 1.13!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Medium priority, add to the next sprint if no P1 available
Projects
None yet
3 participants