Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ONNX FARMReader model conversion is broken #3210

Closed
1 task done
vblagoje opened this issue Sep 13, 2022 · 0 comments · Fixed by #3211
Closed
1 task done

ONNX FARMReader model conversion is broken #3210

vblagoje opened this issue Sep 13, 2022 · 0 comments · Fixed by #3211
Assignees
Labels
type:bug Something isn't working

Comments

@vblagoje
Copy link
Member

Describe the bug
During a recent language and tokenization refactoring we broke FarmReader ONNX conversion support.

Error message
A simple ONNX conversion of a QA model fails; we don't have a test case for it.

onnx_model_path = Path("roberta-onnx-model")
FARMReader.convert_to_onnx(model_name="deepset/roberta-base-squad2", output_path=onnx_model_path)

Expected behavior
Model is converted to ONNX format, written to a local directory and subsequently used to create an ONNX-based reader.

Additional context
None

To Reproduce
Invoke the above-mentioned code sample in the Python interpreter

FAQ Check

System:

  • OS:
  • GPU/CPU:
  • Haystack version (commit or version number):
  • DocumentStore:
  • Reader:
  • Retriever:
@vblagoje vblagoje self-assigned this Sep 13, 2022
@vblagoje vblagoje added the type:bug Something isn't working label Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant