You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We don't specify type hints for many parameters in component constructors. Here is the QuestionGenerator's __init__ constructor to illustrate this issue:
We specify types for the last five parameters but not other parameters. This inconsistency hasn't caused any major issue yet, but it might, and, after all, it is an inconsistency we should correct. The direct consequence I have discovered is that the generated JSON schema doesn't specify the type property for these parameters. In conclusion, for some properties, the Haystack schema has the type field/property, and for others, it doesn't!
Although there are no obvious failures due to this inconsistency, there are no guarantees there might be some in the future. dC tooling will appreciate having types for each component property.
Error message
No error messages were found; there might be silent failures now and in the future.
Expected behavior
We should add type hints for all components' init parameters.
Additional context
None
To Reproduce
Open any Haystack component and view the init method :-)
Describe the bug
We don't specify type hints for many parameters in component constructors. Here is the QuestionGenerator's
__init__
constructor to illustrate this issue:We specify types for the last five parameters but not other parameters. This inconsistency hasn't caused any major issue yet, but it might, and, after all, it is an inconsistency we should correct. The direct consequence I have discovered is that the generated JSON schema doesn't specify the type property for these parameters. In conclusion, for some properties, the Haystack schema has the type field/property, and for others, it doesn't!
Although there are no obvious failures due to this inconsistency, there are no guarantees there might be some in the future. dC tooling will appreciate having types for each component property.
Error message
No error messages were found; there might be silent failures now and in the future.
Expected behavior
We should add type hints for all components' init parameters.
Additional context
None
To Reproduce
Open any Haystack component and view the init method :-)
FAQ Check
System:
The text was updated successfully, but these errors were encountered: