Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add target persona meta information to logs #3004

Closed
tstadel opened this issue Aug 9, 2022 · 1 comment
Closed

Add target persona meta information to logs #3004

tstadel opened this issue Aug 9, 2022 · 1 comment
Labels
type:documentation Improvements on the docs type:feature New feature or request

Comments

@tstadel
Copy link
Member

tstadel commented Aug 9, 2022

As a datascientist I don't want my logs to be cluttered with devops infos.

Is your feature request related to a problem? Please describe.
Currently we do not separate logs according to the persona. devops infos (e.g. availability of multiprocessing, numba, number of worker processes, telemetry) dilutes the logs a data scientist is interested in. Same applies for devops logs regarding data scientist infos (e.g. warnings about which similarity metric to use for some models).

Describe the solution you'd like
We add extra haystack_persona to all logs:

  • value datascience marks logs for data scientists
  • value devops marks logs for devops/data engineers
  • Multiple values are allowed. The type of haystack_persona is an array of values.

Describe alternatives you've considered
Another distinction could be (user-facing vs. backend-applications) but although this has almost the same distribution it is way harder to grasp for notebook users.

Additional context
Main focus lies on bigger deployments using analytics and monitoring tools and a separate UI. Notebook users should also be able to make use of it. The value must be easily filtered for in standard logging and structlog.

@tstadel tstadel added type:feature New feature or request journey:advanced labels Aug 9, 2022
@masci masci added the P3 Low priority, leave it in the backlog label Nov 25, 2022
@masci masci added type:documentation Improvements on the docs and removed action:needs documentation labels Apr 12, 2023
@masci masci removed the P3 Low priority, leave it in the backlog label Apr 26, 2023
@masci
Copy link
Contributor

masci commented Mar 12, 2024

Superseded by structured logging in 2.0

@masci masci closed this as completed Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:documentation Improvements on the docs type:feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants