Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add devices to FARMReader to manually select GPU, CPU etc #1944

Closed
tholor opened this issue Jan 3, 2022 · 0 comments · Fixed by #2294
Closed

Add devices to FARMReader to manually select GPU, CPU etc #1944

tholor opened this issue Jan 3, 2022 · 0 comments · Fixed by #2294
Assignees

Comments

@tholor
Copy link
Member

tholor commented Jan 3, 2022

Is your feature request related to a problem? Please describe.
Currently, we only have the arg use_gpu to configure if the FARMReader should use a GPU. If this is set to true and there's no GPU, we'll fallback to running on a CPU. This is convenient for many dev scenarios, but in production setups there are cases where we need more granular control (e.g. which cuda device to run on, or throwing an error if no GPU is available)

Describe the solution you'd like
We can just use the same param devices as implemented here for DPR

CC @oryx1729

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants