Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Similarity based Answer evaluation #1516

Closed
Timoeller opened this issue May 26, 2021 · 1 comment · Fixed by deepset-ai/FARM#803
Closed

Implement Similarity based Answer evaluation #1516

Timoeller opened this issue May 26, 2021 · 1 comment · Fixed by deepset-ai/FARM#803
Assignees

Comments

@Timoeller
Copy link
Contributor

Following up on research done in deepset-ai/FARM#757

Target Approach

Implementing a new registered metric using the sentencetransformers model.
Also implement a default metric for FARM with default model. Look for ways to pass comparison model to FARM.

Implementation details

Input to our metric functions, preds and labels, are in number format.
Preds are of type QACandidate, but missing text answer information.
Labels are tuples of start and end indices.

Our evaluator.eval pipeline is not meant for dealing with plaintext predictions or labels because we dismiss our "baskets" with all text information. Also using the tokenizer to detokenize input_ids (token ids) will not work since we do not collect input_ids in the evaluator. Therefore we should start an initial implementation based on Inferencer output and not create a default FARM metric.

@Timoeller Timoeller self-assigned this May 26, 2021
@Timoeller
Copy link
Contributor Author

Fixed by deepset-ai/FARM#803

@Timoeller Timoeller transferred this issue from deepset-ai/FARM Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant