Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Farm merging base #1422

Merged
merged 15 commits into from
Sep 16, 2021
Merged

Farm merging base #1422

merged 15 commits into from
Sep 16, 2021

Conversation

Timoeller
Copy link
Contributor

@Timoeller Timoeller commented Sep 7, 2021

epic FARM migration

details mentioned in #1341

In this PR we

  1. move code for QA and DPR from FARM to Haystack.
  2. We adjust code and documentation structure
  3. We add type annotations
  4. We also change the folder structure by putting everything into "haystack.modeling" and will migrate modeling parts from other subpackages (e.g. farm.reader) to modeling eventually

fixes #1389, #1393, #1394, #1395, #1396

julian-risch and others added 8 commits September 9, 2021 11:54
* Fix DPR tests

* Add Tokenizer tests
* Add type annotations in QuestionAnsweringHead

* Fix test by increasing max_seq_len

* Add SampleBasket type annotation

* Remove prediction head param from adaptive model init

* Add type ignore for AdaptiveModel init

* Fix and rename tests

* Adjust folder structure

Co-authored-by: Julian Risch <[email protected]>
@Timoeller Timoeller changed the title WIP: Farm merging base Farm merging base Sep 13, 2021
@tholor tholor linked an issue Sep 14, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FARM migration - integrate tests FARM migration - create base components
4 participants