-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify setup of local tests & update contributor docs #1353
Comments
Just to add a bit of information to this discussion: I think what's still missing from the documentation added in #1355 is a hint that a dev should first install the Furthermore, your Dockerfile does not install the Also if using the docker container shouldn't the tests be run inside the container? Otherwise I'd still have to install all the dependencies locally. So the docs should probably contain a section on SSH'ing into the container and running tests from a shell inside the container. Hope I'm not completely off with my observations. |
Fixed by #1487 |
Is your feature request related to a problem? Please describe.
Our CI works nicely, but it's currently quite cumbersome to run all tests locally. Especially, as they require running some document stores in the background.
Describe the solution you'd like
--document_store
param to run all tests with the docstore of ones choice (e.g.document_store=memory
should cover all major functionalities and only leave out the tests that are highly specific for elastic, faiss & co)The text was updated successfully, but these errors were encountered: