Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tutorial 22 shows irrelevant results #208

Closed
anakin87 opened this issue Jun 22, 2023 · 2 comments · Fixed by #239
Closed

Tutorial 22 shows irrelevant results #208

anakin87 opened this issue Jun 22, 2023 · 2 comments · Fixed by #239
Labels
enhancement New feature or request

Comments

@anakin87
Copy link
Member

As we noticed together with @bilgeyucel,
currently the Tutorial 22 produces some irrelevant results,
possibly due to prompt truncation.

Since it has great importance, we should ensure that it produces good results.
@anakin87 anakin87 added the enhancement New feature or request label Jun 22, 2023
@bilgeyucel
Copy link
Contributor

There are two options here:

  • Try another open source model with a larger context limit
    • Should be runnable on Colab (or we can use HuggingFace Inference API but this requires a key)
  • Update the dataset we're using by splitting files with a smaller window size

@TuanaCelik
Copy link
Member

Thanks for spotting this ppl! Another option is to use one of the other datasets we have. We now have quite a few we can pick from on HF: presidents, pycon, seven wonders (current) and game of thrones.

@bilgeyucel bilgeyucel mentioned this issue Oct 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change the model used in RAG tutorial deepset-ai/haystack-tutorials
3 participants
@TuanaCelik @bilgeyucel @anakin87