Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add working query pipeline example code to elasticsearch-document-store.md #100

Merged
merged 2 commits into from
Dec 27, 2023
Merged

add working query pipeline example code to elasticsearch-document-store.md #100

merged 2 commits into from
Dec 27, 2023

Conversation

annthurium
Copy link
Contributor

@annthurium annthurium commented Dec 21, 2023 •
edited
Loading

fixes #98

test strategy:

  • start up Elasticsearch instance
  • run code locally

output:

{'retriever': {'documents': [Document(id=6383dc3ed51fc90c2e45704853a7ad9b14168f4f262ac7a0b65e02c465d0bb1c, content: 'Historic Areas of Istanbul
With its strategic location on the Bosphorus peninsula between the Balkan...', meta: {'file_path': 'filename.txt', 'source_id': 'bb4b4bbec446c13f103bd0ec1777cbb424ae6d2bef355b17a5e299e97e9d4f55'}, score: 0.82134724, embedding: vector of size 1024)]}}

@annthurium annthurium changed the title add working query pipeline example code to add working query pipeline example code to elasticsearch-document-store.md Dec 21, 2023
@annthurium annthurium added the documentation Improvements or additions to documentation label Dec 21, 2023
@annthurium annthurium self-assigned this Dec 22, 2023
TuanaCelik
TuanaCelik approved these changes Dec 27, 2023
View reviewed changes
Copy link
Member

@TuanaCelik TuanaCelik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to add, merge away

@annthurium annthurium merged commit 6cf3832 into main Dec 27, 2023
@annthurium annthurium deleted the tt-2023-dec-fix-elasticsearch-md branch December 27, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TuanaCelik TuanaCelik TuanaCelik approved these changes

@bilgeyucel bilgeyucel Awaiting requested review from bilgeyucel

Assignees

@annthurium annthurium

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

code examples in elasticsearch-document-store.md throw errors
2 participants
@annthurium @TuanaCelik