Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Cohere integration page #59

Merged
merged 1 commit into from
Oct 15, 2023
Merged

Add Cohere integration page #59

merged 1 commit into from
Oct 15, 2023

Conversation

bilgeyucel
Copy link
Contributor

@bilgeyucel bilgeyucel commented Oct 13, 2023 •
edited

Fixes #60

@bilgeyucel bilgeyucel self-assigned this Oct 13, 2023
TuanaCelik
TuanaCelik reviewed Oct 15, 2023
View reviewed changes
Copy link
Member

@TuanaCelik TuanaCelik left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Didn't see the embedding models initially, idk why. @dfokina I think we should make them a bit clearer in the docs for each category though. Rankers is clear but for the PromptNode and Embedding models you kinda have to do some digging in docs to find out.
This will be a lot clearer in Haystack 2.0 by nature so we'll be good in that respect.

@TuanaCelik TuanaCelik merged commit bb1443b into main Oct 15, 2023
@TuanaCelik TuanaCelik deleted the cohere-integration branch October 15, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TuanaCelik TuanaCelik TuanaCelik approved these changes

Assignees

@bilgeyucel bilgeyucel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prepare Cohere Integration Page
2 participants
@bilgeyucel @TuanaCelik